Closed
Conversation
kwmonroe
force-pushed
the
kafka
branch
4 times, most recently
from
7a97bdb to
6e3f416
Compare
Squashed changes:
* Advertise hostname in server.properties
* Opening kafka ports
* lint; close ports
* Fixed up tests.
* Tests were failing due to some ambiguities in the version of zookeeper
that we are deploying. Fixed them so that they work with my setup (juju
2.0, installing zookeeper from the charms store), and have some checks
that should make them work with other setups.
* Also fixed a mistake, where the deploy test was calling self.unit, but
had set self.kafka.
* Added ability to override host.name (bind address) for kafka
* Got rid of try-catch in tests, and fixed defaults.
* config.yaml should default to null, rather than 0.0.0.0
(They both do the same thing, basically, but 'null' results in nothing
being written to server.properties.)
Changed name to "network_interface". You may now pass an interface name or a CIDR range, and juju will figure out the correct ip address to drop into the server.properties config.
Added documentation on the network_interface config value to README, added tests, and made the way that variables get passed to configure_kafka more consistent.
Contributor
|
Tests pass with flying colors when run with bundletester. Code looks good. I am +1 to merge this. :-) |
Without -r flag, hook won't auto retry.
Cleaning up "loose ends" from previous PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.