[bookie-http-server] Fix: broken vertx rest endpoints#1953
Merged
sijie merged 1 commit intoapache:masterfrom Feb 25, 2019
Merged
[bookie-http-server] Fix: broken vertx rest endpoints#1953sijie merged 1 commit intoapache:masterfrom
sijie merged 1 commit intoapache:masterfrom
Conversation
sijie
approved these changes
Feb 20, 2019
| @Override | ||
| public void bindHandler(String endpoint, VertxAbstractHandler handler) { | ||
| router.get(endpoint).handler(handler); | ||
| router.put(endpoint).handler(handler); |
Member
There was a problem hiding this comment.
interesting... I am wondering why it was not captured by our tests. /cc @jiazhai can you check do we have test coverage of gc endpoint?
Contributor
Author
There was a problem hiding this comment.
I think test only covers get and not the put. I will add test for triggering gc.
Member
|
run integration tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, vertx-http-server is not serving any rest endpoint except get because vertx server doesn't add put/post/delete http-methods into routing rules.
Modification
Add put/post/delete http-methods into routing rules.