Skip to content

[bookie-http-server] Fix: broken vertx rest endpoints #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sijie merged 1 commit into from
Feb 25, 2019
Merged

[bookie-http-server] Fix: broken vertx rest endpoints #1953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ttp/vertx-http-server/src/main/java/org/apache/bookkeeper/http/vertx/VertxHttpServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ public boolean startServer(int port) {
@Override
public void bindHandler(String endpoint, VertxAbstractHandler handler) {
router.get(endpoint).handler(handler);
router.put(endpoint).handler(handler);
Copy link
Member

@sijie sijie Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting... I am wondering why it was not captured by our tests. /cc @jiazhai can you check do we have test coverage of gc endpoint?

Copy link
Contributor Author

@rdhabalia rdhabalia Feb 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think test only covers get and not the put. I will add test for triggering gc.

router.post(endpoint).handler(handler);
router.delete(endpoint).handler(handler);
}
};
requestRouter.bindAll();
Expand Down