Optimized debug log enable#3596
Merged
Merged
Conversation
Contributor
|
Why not adjust log level to print debug logs? |
Member
Author
|
rerun failure checks |
Member
Author
@yaalsn Why adjust the log level? Debug logs are generally only dynamically enabled and used when troubleshooting is required. |
Contributor
|
@wenbingshen Would you please explain the improvements of this change? |
merlimat
approved these changes
Nov 1, 2022
Contributor
|
@hangc0276 the |
hangc0276
approved these changes
Nov 1, 2022
Member
Author
|
@merlimat Thanks for your explanation and review! :) |
yaalsn
pushed a commit
to yaalsn/bookkeeper
that referenced
this pull request
Jan 30, 2023
* Optimized debug log enable * Unified debug log enable
This was referenced Feb 2, 2023
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
* Optimized debug log enable * Unified debug log enable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As the title.