[improve] [Follow-PR#3596] Optimize log trace enable to reduce allocating objects#3764
Closed
wenbingshen wants to merge 1 commit into
Closed
[improve] [Follow-PR#3596] Optimize log trace enable to reduce allocating objects#3764wenbingshen wants to merge 1 commit into
wenbingshen wants to merge 1 commit into
Conversation
Member
Author
|
@hangc0276 PTAL. Thanks! |
nicoloboschi
requested changes
Feb 2, 2023
Contributor
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
If there's no computation to get the value to print, there's no need to add those conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following PR #3596