Issue 507: Introduce @FlakyTest annotation for marking a few tests as flaky#504
Issue 507: Introduce @FlakyTest annotation for marking a few tests as flaky#504sijie wants to merge 3 commits intoapache:masterfrom
Conversation
- introduced FlakyTest annotation - mark a few tests as flaky tests (create issues for them)
|
It is WIP - try to use the precommit jenkins job debugging the flaky test. (I'd like to bring the CI back to normal state as soon as possible) |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
| readEntries.hasMoreElements();) { | ||
| LedgerEntry entry = readEntries.nextElement(); | ||
| assertTrue(entry.data.getClass().getName(), | ||
| entry.data.getClass().getName().contains("PooledNonRetainedSlicedByteBuf")); |
There was a problem hiding this comment.
why are you removing this checks ? they are 'poor man' checks about the fact that we are pooling/non-pooling the ByteBuf. it is important to check that in v2 protocol bytebufs are "pooled"
There was a problem hiding this comment.
this check is not correct, and depends heavily on the implementation of netty. because the class can be SimpleLeakAwareByteBuf.
There was a problem hiding this comment.
There was a problem hiding this comment.
@sijie OK I am convinced.
It is a pity that we are not able to made a usable assertion :-(
the error is
java.lang.AssertionError: io.netty.buffer.SimpleLeakAwareByteBuf
at org.apache.bookkeeper.client.BookKeeperTest.testReadEntryReleaseByteBufs(BookKeeperTest.java:742)
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
sijie
changed the title
|
removed the debug logging (was unable to reproduce the failed test). turn this pull request to introduce |
|
Refer to this link for build results (access rights to CI server needed): |
…ests as flaky Descriptions of the changes in this PR: - introduced FlakyTest annotation - mark a few tests as flaky tests (create issues for them) Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None> This closes apache#504 from sijie/mark_test_as_failures, closes apache#507
…s flaky Descriptions of the changes in this PR: - introduced FlakyTest annotation - mark a few tests as flaky tests (create issues for them) Author: Sijie Guo <sijieapache.org> Reviewers: Jia Zhai <None> This closes #504 from sijie/mark_test_as_failures, closes #507 Descriptions of the changes in this PR: (PR description content here)... Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes #710 from ivankelly/flakey-4.5, closes #507
4 participants
Descriptions of the changes in this PR: