ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky#710
Closed
ivankelly wants to merge 1 commit intoapache:branch-4.5from
Closed
ISSUE #507: Introduce @FlakyTest annotation for marking a few tests as flaky#710ivankelly wants to merge 1 commit intoapache:branch-4.5from
ivankelly wants to merge 1 commit intoapache:branch-4.5from
Conversation
…ests as flaky Descriptions of the changes in this PR: - introduced FlakyTest annotation - mark a few tests as flaky tests (create issues for them) Author: Sijie Guo <sijie@apache.org> Reviewers: Jia Zhai <None> This closes apache#504 from sijie/mark_test_as_failures, closes apache#507
eolivelli
approved these changes
Nov 9, 2017
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
+1 this is for 4.5 branch.
The merge script on master handles this case, there is an ENV variable with the target branch.
I can merge this on this evening, if you prefer @ivankelly or @jiazhai you can merge now to see the new results
|
FAILURE --none-- |
sijie
approved these changes
Nov 9, 2017
Member
|
I will have a try |
Contributor
|
I am merging this into 4.5 |
Contributor
|
are you trying too @jiazhai ? |
jiazhai
pushed a commit
that referenced
this pull request
Nov 10, 2017
…s flaky Descriptions of the changes in this PR: - introduced FlakyTest annotation - mark a few tests as flaky tests (create issues for them) Author: Sijie Guo <sijieapache.org> Reviewers: Jia Zhai <None> This closes #504 from sijie/mark_test_as_failures, closes #507 Descriptions of the changes in this PR: (PR description content here)... Author: Sijie Guo <sijie@apache.org> Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Sijie Guo <sijie@apache.org> This closes #710 from ivankelly/flakey-4.5, closes #507
Member
|
what a coincidence for us to do it at same time, will close this, since it is merged. |
athanatos
pushed a commit
to athanatos/bookkeeper
that referenced
this pull request
Jan 25, 2019
Summary: client-initiated renegotiation is insecure and is vulnerable to MITM attacks. Unfortunately, the feature is enabled in Java by default. This disables it. See https://bugs.openjdk.java.net/browse/JDK-7188658 and https://www.oracle.com/technetwork/java/javase/documentation/tlsreadme-141115.html Test Plan: manually tested by running a secure ZK server and probing the listening port with python's sslyze tool (using `sslyze --reneg ...`). Tested on Java 8, 9, 10, and 11. Author: Ilya Maykov <ilyam@fb.com> Reviewers: andor@apache.org Closes apache#710 from ivmaykov/ZOOKEEPER-3195
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Author: Sijie Guo sijie@apache.org
Reviewers: Jia Zhai
This closes #504 from sijie/mark_test_as_failures, closes #507
Descriptions of the changes in this PR:
(PR description content here)...