Skip to content

BOOKKEEPER-971: update bk codahale stats provider version#83

Closed
jiazhai wants to merge 4 commits intoapache:masterfrom
jiazhai:BOOKKEEPER-971
Closed

BOOKKEEPER-971: update bk codahale stats provider version#83
jiazhai wants to merge 4 commits intoapache:masterfrom
jiazhai:BOOKKEEPER-971

Conversation

@jiazhai
Copy link
Copy Markdown
Member

@jiazhai jiazhai commented Nov 25, 2016 •
edited
Loading

Update bk stats provider: from codahale to yammer.
Currently io.dropwizard.metrics 3.1.0 is used most widely. will change version to 3.1.0.

And change CodahaleMetricsProvider.getMetrics() to public, since this would be used outside package.

And a small bug here:

            File outdir;
            if (Strings.isNullOrEmpty(prefix)) {  < === if (!)
                outdir = new File(csvDir, prefix);
            } else {
                outdir = new File(csvDir);
            }

@sijie
Copy link
Copy Markdown
Member

sijie commented Nov 28, 2016

LGTM +1

@asfgit asfgit closed this in be99f02 Dec 17, 2016
sijie pushed a commit to sijie/bookkeeper that referenced this pull request Jan 26, 2018
@sijie
DL-150: Ensure namespace path is created for TestZKLogMetadataForWriter
30742c0 
Author: Sijie Guo <sijieg@twitter.com>

Reviewers: Leigh Stewart <lstewart@apache.org>

Closes apache#83 from sijie/sijie/FixTestCreateLogMetadata
reddycharan pushed a commit to reddycharan/bookkeeper that referenced this pull request May 21, 2018
(@bug W-4755567@) codahaleStatsOutputFrequencySeconds: consistency an…
de42dfa 
…d clarifications (apache#83)

* bk_replication.conf consistency with SdbStoreOps Prod-Operations/MetricStreamer/config
* codahaleStatsOutputFrequencySeconds targets clarifications

@Rev dcastor@
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jiazhai @sijie