Skip to content

BOOKKEEPER-971: update bk codahale stats provider version #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jiazhai wants to merge 4 commits into from
Closed

BOOKKEEPER-971: update bk codahale stats provider version #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba1c99f
Merge pull request #1 from apache/master
jiazhai Nov 9, 2016
68052aa
update codahale version
Nov 25, 2016
486220f
change getMetrics to public
Nov 26, 2016
5b83db8
a small bug
Dec 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions bookkeeper-stats-providers/codahale-metrics-provider/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,24 @@
<artifactId>bookkeeper-stats-api</artifactId>
<version>${project.parent.version}</version>
</dependency>

<!-- https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-core -->
<dependency>
<groupId>com.codahale.metrics</groupId>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-core</artifactId>
<version>3.0.1</version>
<version>3.1.0</version>
</dependency>
<!-- https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-jvm -->
<dependency>
<groupId>com.codahale.metrics</groupId>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-jvm</artifactId>
<version>3.0.1</version>
<version>3.1.0</version>
</dependency>
<!-- https://mvnrepository.com/artifact/io.dropwizard.metrics/metrics-graphite -->
<dependency>
<groupId>com.codahale.metrics</groupId>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-graphite</artifactId>
<version>3.0.1</version>
<version>3.1.0</version>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
Expand Down
4 changes: 2 additions & 2 deletions ...e-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleMetricsProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ synchronized void initIfNecessary() {
}
}

synchronized MetricRegistry getMetrics() {
public synchronized MetricRegistry getMetrics() {
return metrics;
}

Expand Down Expand Up @@ -94,7 +94,7 @@ public void start(Configuration conf) {
// 2/ the output directory must exist
// 3/ if output files already exist they are not overwritten and there is no metrics output
File outdir;
if (Strings.isNullOrEmpty(prefix)) {
if (!Strings.isNullOrEmpty(prefix)) {
outdir = new File(csvDir, prefix);
} else {
outdir = new File(csvDir);
Expand Down