fix(bthread): drop unimplemented barrier and rwlockattr APIs - #3504
Open
darion-yaphet wants to merge 1 commit into
Open
fix(bthread): drop unimplemented barrier and rwlockattr APIs#3504darion-yaphet wants to merge 1 commit into
darion-yaphet wants to merge 1 commit into
Conversation
These declarations had no definitions, so calling them failed at link time. Keep bthread_rwlockattr_t for bthread_rwlock_init(). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
bthread.hdeclared POSIX-style barrier APIs (bthread_barrier_init/destroy/wait) and rwlock attribute APIs (bthread_rwlockattr_init/destroy/getkind_np/setkind_np) that were never defined inlibbrpc. Compiling against the headers succeeded, then linking failed withundefined reference. The headers advertised an API that the library does not provide.What is changed and the side effects?
Changed:
bthread_barrier_*declarations and the unusedbthread_barrier_t/bthread_barrierattr_ttypes.bthread_rwlockattr_*declarations.bthread_rwlockattr_tbecause it is still the argument type of the implementedbthread_rwlock_init().bthread_rwlock_init()currently ignoresattr.Side effects:
Performance effects: none.
Breaking backward compatibility: source-incompatible only for code that called these never-linked symbols. Working programs that already linked against brpc could not have been using them.
bthread_rwlock_init()signature is unchanged.Check List: