Skip to content

Remove bst-artifact-server#1526

Merged
gtristan merged 3 commits into
masterfrom
tristan/remove-artifact-server
Oct 25, 2021
Merged

Remove bst-artifact-server#1526
gtristan merged 3 commits into
masterfrom
tristan/remove-artifact-server

Conversation

@gtristan
Copy link
Copy Markdown
Contributor

This fixes #1468

@juergbi
Copy link
Copy Markdown
Contributor

juergbi commented Oct 11, 2021

At the very least for testing we need to keep the server around. It makes sense to remove it from the list of entry points to install to make it clear that we recommend better servers for production use. However, for testing, this trivial implementation is sensible, in my opinion.

@gtristan
Copy link
Copy Markdown
Contributor Author

At the very least for testing we need to keep the server around. It makes sense to remove it from the list of entry points to install to make it clear that we recommend better servers for production use. However, for testing, this trivial implementation is sensible, in my opinion.

Perhaps we should move it to the tests directory, or better yet, to buildstream.testing...

@gtristan gtristan force-pushed the tristan/remove-artifact-server branch from 20bb5a3 to 01f89a5 Compare October 12, 2021 05:03
@gtristan
Copy link
Copy Markdown
Contributor Author

[...]
Perhaps we should move it to the tests directory, or better yet, to buildstream.testing...

Scratch that, I think it makes better sense to keep it all together with it's family in the _cas/ subdir.

I'll finish this up by amending documentation and explaining how to use bb-storage and bb-remote-asset

@gtristan gtristan force-pushed the tristan/remove-artifact-server branch 2 times, most recently from cd8fe50 to 0bdba89 Compare October 12, 2021 05:20
Since we are removing the artifact server entrypoint, we will only run
the service tests using buildbarn.
@gtristan gtristan force-pushed the tristan/remove-artifact-server branch from 0bdba89 to 5138b50 Compare October 17, 2021 07:48
This patch removes the documentation about the removed `bst-artifact-server`
and documents BuildStream's neutral stance as requiring any implementation
of the ContentAddressableStorage and RemoteAsset protocols.

A list of known implementations is given with only Buildbarn listed
for now, with a small simple example and links given.
@gtristan gtristan changed the title WIP: Remove bst-artifact-server Remove bst-artifact-server Oct 17, 2021
@gtristan gtristan merged commit f6181e7 into master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove bst-artifact-server

2 participants