fix(testing): read test case json as utf-8 - #872
Merged
Conversation
jernejfrank
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Burr's generated pytest test-case JSON path used the platform default encoding when appending fixtures from
burr test-case createand when loading those fixtures throughburr.testing.load_test_cases().Those JSON files can contain serialized application state, prompts, responses, or user text. On systems whose default encoding is not UTF-8, fixtures with non-ASCII text can fail to load or be interpreted inconsistently.
Before / after
Before, the CLI writer and pytest helper opened test-case JSON files without specifying an encoding.
After, both the generated fixture writer and
load_test_cases()read/write those JSON files withencoding="utf-8". A focused regression test writes a UTF-8 JSON fixture with literal non-ASCII text and verifies it loads with the expected test id and state payloads.Verification
python -m pytest tests/test_testing.py tests/integrations/test_burr_pydantic_future_annotations.pygit diff --check