[CALCITE-2292] Query result is wrong when table is implemented with F…#1182
Merged
hsyuan merged 1 commit intoapache:masterfrom Apr 29, 2019
Merged
[CALCITE-2292] Query result is wrong when table is implemented with F…#1182hsyuan merged 1 commit intoapache:masterfrom
hsyuan merged 1 commit intoapache:masterfrom
Conversation
…ilterableTable and the sql has multiple where conditions
chunweilei
commented
Apr 26, 2019
| case IS_NOT_NULL: | ||
| return NullAs.IS_NULL; | ||
| default: | ||
| return nullAs; |
Contributor
Author
There was a problem hiding this comment.
Before this change, the generated code for conditions like name like 'ss' and name not like 'xx' is
inp1_ == null || inp1_ != null ? (Boolean) null : Boolean.TRUE)
which is wrong because it always return null.
After this change it becomes
inp1_ == null ? (Boolean) null : Boolean.TRUE.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ilterableTable and the sql has multiple where conditions
JIRA: https://issues.apache.org/jira/browse/CALCITE-2292.