Skip to content

[CALCITE-2292] Query result is wrong when table is implemented with F… #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsyuan merged 1 commit into from
Apr 29, 2019
Merged

[CALCITE-2292] Query result is wrong when table is implemented with F… #1182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,10 @@ private NullAs negate(NullAs nullAs) {
return NullAs.TRUE;
case TRUE:
return NullAs.FALSE;
case IS_NULL:
return NullAs.IS_NOT_NULL;
case IS_NOT_NULL:
return NullAs.IS_NULL;
default:
return nullAs;
Copy link
Contributor Author

@chunweilei chunweilei Apr 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change, the generated code for conditions like name like 'ss' and name not like 'xx' is
inp1_ == null || inp1_ != null ? (Boolean) null : Boolean.TRUE)
which is wrong because it always return null.
After this change it becomes
inp1_ == null ? (Boolean) null : Boolean.TRUE.

}
Expand Down
23 changes: 23 additions & 0 deletions example/csv/src/test/java/org/apache/calcite/test/CsvTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,29 @@ private static StringBuilder escapeString(StringBuilder buf, String s) {
.returns("EMPNO=130; GENDER=F; NAME=Alice").ok();
}

/** Test case for
* <a href="https://issues.apache.org/jira/browse/CALCITE-2272">[CALCITE-2272]
* Incorrect result for {@code name like '%E%' and city not like '%W%'}</a>.
*/
@Test public void testFilterableWhereWithNot1() throws SQLException {
sql("filterable-model",
"select name, empno from EMPS "
+ "where name like '%E%' and city not like '%W%' ")
.returns("NAME=Eric; EMPNO=110")
.ok();
}

/** Similar to {@link #testFilterableWhereWithNot1()};
* But use the same column. */
@Test public void testFilterableWhereWithNot2() throws SQLException {
sql("filterable-model",
"select name, empno from EMPS "
+ "where name like '%i%' and name not like '%W%' ")
.returns("NAME=Eric; EMPNO=110",
"NAME=Alice; EMPNO=130")
.ok();
}

@Test public void testJson() throws SQLException {
final String sql = "select _MAP['id'] as id,\n"
+ " _MAP['title'] as title,\n"
Expand Down