Skip to content

[CALCITE-3421] Reuse relMetadataQuery and fix doc in LogicalCalc - #1513

Closed
xy2953396112 wants to merge 1 commit into
apache:masterfrom
xy2953396112:RelMetadataQuery
Closed

[CALCITE-3421] Reuse relMetadataQuery and fix doc in LogicalCalc#1513
xy2953396112 wants to merge 1 commit into
apache:masterfrom
xy2953396112:RelMetadataQuery

Conversation

@xy2953396112

Copy link
Copy Markdown
Contributor

Reuse relMetadataQuery in TraitPropagationTest,VolcanoPlannerTraitTest,RelMetadataTest,PlannerTest

@xy2953396112 xy2953396112 changed the title [CALCITE-3421] Reuse relMetadataQuery. [CALCITE-3421] Reuse relMetadataQuery and fix doc in LogicalCalc Oct 16, 2019
@xy2953396112

Copy link
Copy Markdown
Contributor Author

CC @danny0405

@danny0405 danny0405 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change, @hsyuan , can you also take a look ?

@jinxing64

Copy link
Copy Markdown
Contributor

LGTM.
Just one question ~
As discussed on the mailing list [DISCUSSION] Extension of Metadata Query, if the lifespan of RelMetadataQuery is a RelOptCall, it seems weird to get a RelMetadataQuery instance from RelOptCluster.

@hsyuan hsyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsyuan hsyuan closed this in ebc16af Oct 17, 2019
XuQianJin-Stars pushed a commit to XuQianJin-Stars/calcite that referenced this pull request Nov 17, 2019
XuQianJin-Stars pushed a commit to XuQianJin-Stars/calcite that referenced this pull request Nov 20, 2019
XuQianJin-Stars pushed a commit to XuQianJin-Stars/calcite that referenced this pull request Nov 20, 2019
wangxlong pushed a commit to wangxlong/calcite that referenced this pull request Feb 13, 2020
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Aug 28, 2025
Close apache#1513

Change-Id: If5ea6d49ed25be9d0d9abf6fcda4adcefcf170b6
jamesstarr pushed a commit to jamesstarr/calcite that referenced this pull request Mar 16, 2026
Close apache#1513

Change-Id: If5ea6d49ed25be9d0d9abf6fcda4adcefcf170b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants