Skip to content

[CALCITE-3451] Support TableModify in RelMdNodeTypes. #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xy2953396112 wants to merge 2 commits into from
Closed

[CALCITE-3451] Support TableModify in RelMdNodeTypes. #1535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2501017
Support TableModify in RelMdNodeTypes.
xy2953396112 Oct 26, 2019
6407c07
fix import order.
xy2953396112 Oct 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/java/org/apache/calcite/rel/metadata/RelMdNodeTypes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import org.apache.calcite.rel.core.Minus;
import org.apache.calcite.rel.core.Project;
import org.apache.calcite.rel.core.Sort;
import org.apache.calcite.rel.core.TableModify;
import org.apache.calcite.rel.core.TableScan;
import org.apache.calcite.rel.core.Union;
import org.apache.calcite.rel.core.Values;
Expand Down Expand Up @@ -128,6 +129,11 @@ public Multimap<Class<? extends RelNode>, RelNode> getNodeTypes(Values rel,
return getNodeTypes(rel, Values.class, mq);
}

public Multimap<Class<? extends RelNode>, RelNode> getNodeTypes(TableModify rel,
RelMetadataQuery mq) {
return getNodeTypes(rel, TableModify.class, mq);
}

@jinxing64 jinxing64 Oct 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


private static Multimap<Class<? extends RelNode>, RelNode> getNodeTypes(RelNode rel,
Class<? extends RelNode> c, RelMetadataQuery mq) {
final Multimap<Class<? extends RelNode>, RelNode> nodeTypeCount = ArrayListMultimap.create();
Expand Down
10 changes: 10 additions & 0 deletions core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.apache.calcite.rel.core.Minus;
import org.apache.calcite.rel.core.Project;
import org.apache.calcite.rel.core.Sort;
import org.apache.calcite.rel.core.TableModify;
import org.apache.calcite.rel.core.TableScan;
import org.apache.calcite.rel.core.Union;
import org.apache.calcite.rel.core.Values;
Expand Down Expand Up @@ -2350,6 +2351,15 @@ private void checkNodeTypeCount(String sql, Map<Class<? extends RelNode>, Intege
checkNodeTypeCount(sql, expected);
}

@Test public void testNodeTypeTableModify() {

@jinxing64 jinxing64 Oct 27, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming as testNodeTypeCountTableModify ?

final String sql = "insert into emp select * from emp";
final Map<Class<? extends RelNode>, Integer> expected = new HashMap<>();
expected.put(TableScan.class, 1);
expected.put(TableModify.class, 1);
expected.put(Project.class, 1);
checkNodeTypeCount(sql, expected);
}

@Test public void testNodeTypeCountJoinFinite() {
final String sql = "select * from (select * from emp limit 14) as emp\n"
+ "inner join (select * from dept limit 4) as dept\n"
Expand Down