[CALCITE-3576] Remove enumerable convention check in FilterIntoJoinRule#1639
Merged
Conversation
danny0405
reviewed
Dec 7, 2019
| join.getConvention() != EnumerableConvention.INSTANCE; | ||
|
|
||
| /** Rule that pushes predicates from a Filter into the Join below them. */ | ||
| public static final FilterJoinRule FILTER_ON_JOIN = |
Contributor
There was a problem hiding this comment.
We can remove the predicate member if it always returns true.
Contributor
There was a problem hiding this comment.
+1
I guess the intention here is for backward compatibility, since the constructor of FilterIntoJoinRule is public
Member
Author
There was a problem hiding this comment.
I don't mind removing it if you think the backward compatibility is not a concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.