[CALCITE-3552] Support MySQL ExtractValue function#1645
Merged
chunweilei merged 2 commits intoDec 16, 2019
Conversation
danny0405
reviewed
Dec 11, 2019
| * The <code>EXTRACTVALUE</code> function. | ||
| */ | ||
| public class SqlExtractValueFunction extends SqlFunction { | ||
|
|
Contributor
There was a problem hiding this comment.
This class is not that necessary, use SqlFunction directly is okey. We only need new class when we want to customize the operands/return type inference.
danny0405
approved these changes
Dec 11, 2019
chunweilei
reviewed
Dec 12, 2019
| ReturnTypes.cascade(ReturnTypes.VARCHAR_2000, SqlTypeTransforms.FORCE_NULLABLE), | ||
| null, OperandTypes.STRING_STRING, SqlFunctionCategory.SYSTEM); | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Oracle also has this function[1]. Is it the same?
[1] https://docs.oracle.com/cd/B19306_01/server.102/b14200/functions052.htm
Contributor
Author
There was a problem hiding this comment.
Reading the docs, seems like there is difference in behaviour of MySql ExtractValue and Oracle ExtractValue.
danny0405
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.