[CALCITE-3847] Decorrelation for join with lateral table outputs wron… - #1850
Merged
Conversation
…g plan if the join condition contains correlation variables
vvysotskyi
reviewed
Mar 9, 2020
| return decorrelateRel((RelNode) rel); | ||
| } | ||
|
|
||
| public Frame decorrelateRel(LogicalTableFunctionScan rel) { |
Member
There was a problem hiding this comment.
This class also contains methods for non-logical rel nodes, for example, decorrelateRel(Filter rel). Should be TableFunctionScan there instead of LogicalTableFunctionScan to ensure that this issue wouldn't be reproduced for other implementations of TableFunctionScan?
Contributor
Author
There was a problem hiding this comment.
Decoration should only happen for logical nodes, we keep node Filter only for compatibility with old version Calcite.
Member
There was a problem hiding this comment.
Ok, thanks for the explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g plan if the join condition contains correlation variables