Merged
Conversation
rubenada
reviewed
Nov 5, 2020
rubenada
reviewed
Nov 6, 2020
Contributor
|
Thanks for the PR @geetha-rangaswamaiah , I have no further comments. |
rubenada
added
the
LGTM-will-merge-soon
Contributor
|
@geetha-rangaswamaiah a final detail: could you please adjust the commit message to have a simple one; and also please add your name in parentheses at the end of the message (see https://calcite.apache.org/develop/#contributing), e.g. "Fix grammatical errors in documentation (name)" |
Contributor
|
Thanks @geetha-rangaswamaiah for your contribution! |
ghost
deleted the
patch13
branch
November 10, 2020 07:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes grammatical errors