Skip to content

Remove useless explicit type cast when using SqlValidator - #2785

Merged
chunweilei merged 1 commit into
apache:mainfrom
chunweilei:useless_cast2
May 6, 2022
Merged

Remove useless explicit type cast when using SqlValidator#2785
chunweilei merged 1 commit into
apache:mainfrom
chunweilei:useless_cast2

Conversation

@chunweilei

Copy link
Copy Markdown
Contributor

No description provided.

@rubenada

rubenada commented May 4, 2022

Copy link
Copy Markdown
Contributor

+1.
I think the same change can be applied to SqlInOperator:148 and SqlJsonObjectAggAggFunction:77

@chunweilei

Copy link
Copy Markdown
Contributor Author

+1. I think the same change can be applied to SqlInOperator:148 and SqlJsonObjectAggAggFunction:77

Nice catch. I have updated the PR. Thank you for your review.

@chunweilei chunweilei added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label May 5, 2022
@chunweilei
chunweilei merged commit 737df39 into apache:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants