Skip to content

[CALCITE-5149] Refine RelMdColumnUniqueness for Aggregate by considering intersect keys between target keys and group keys - #2805

Merged
chunweilei merged 1 commit into
apache:mainfrom
chunweilei:CALCITE-5149
May 18, 2022
Merged

[CALCITE-5149] Refine RelMdColumnUniqueness for Aggregate by considering intersect keys between target keys and group keys#2805
chunweilei merged 1 commit into
apache:mainfrom
chunweilei:CALCITE-5149

Conversation

@chunweilei

Copy link
Copy Markdown
Contributor

No description provided.

@chunweilei
chunweilei force-pushed the CALCITE-5149 branch 2 times, most recently from a1d68c6 to 61a9a79 Compare May 13, 2022 07:50

@hsyuan hsyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunweilei chunweilei changed the title [CALCITE-5149] Refine RelMdColumnUniqueness for Aggregate by considering intersect keys [CALCITE-5149] Refine RelMdColumnUniqueness for Aggregate by considering intersect keys between target keys and group keys May 16, 2022
@chunweilei chunweilei added the LGTM-will-merge-soon Overall PR looks OK. Only minor things left. label May 16, 2022
…ing intersect keys between target keys and group keys
@chunweilei

Copy link
Copy Markdown
Contributor Author

Thank you for your review, @hsyuan. I will merge this PR in the coming days if no objection appears.

@chunweilei
chunweilei merged commit c5d45cb into apache:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LGTM-will-merge-soon Overall PR looks OK. Only minor things left.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants