[CALCITE-5260] Pop the last RelNode added into the bindings list when failing to apply a rule - #2891
Open
wangyeweikuer wants to merge 1 commit into
Open
[CALCITE-5260] Pop the last RelNode added into the bindings list when failing to apply a rule#2891wangyeweikuer wants to merge 1 commit into
wangyeweikuer wants to merge 1 commit into
Conversation
…en fail to match a subtree (mengdou)
Member
|
@wangyeweikuer Thanks for your contribution, could you add some tests which will fail without your fix? This will make us easier to understand the PR. |
chunweilei
reviewed
Sep 20, 2022
| Stack<RelNode> bindings, | ||
| Map<RelNode, List<RelNode>> nodeChildren) { | ||
| if (!operand.matches(rel)) { | ||
| return false; |
Contributor
There was a problem hiding this comment.
Could you add a test case?
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
June 8, 2023 21:21
8a5cf83 to
cf7f71b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fail to match a subtree, HepPlanner should pop the last RelNode added into the bindings list, where the nodes left are 'real' matched when applying a rule.
Otherwise, using some temporary and unnecessary nodes to construct a HepRuleCall will cause an assertion error.