[CALCITE-5267] Remove unused variable 'newCasts' in AggregateCaseToF… - #2895
Closed
zhuwenzhuang wants to merge 2 commits into
Closed
[CALCITE-5267] Remove unused variable 'newCasts' in AggregateCaseToF…#2895zhuwenzhuang wants to merge 2 commits into
zhuwenzhuang wants to merge 2 commits into
Conversation
chunweilei
reviewed
Sep 6, 2022
Contributor
Author
I guess the code "relBuilder.aggregate(groupKey, newCalls).convert(aggregate.getRowType(), false)" is a better way to do CAST. So we don't need to save every project to keep types stable. |
libenchao
approved these changes
Sep 19, 2022
libenchao
left a comment
libenchao
left a comment
Member
There was a problem hiding this comment.
LGTM, Thanks for your contribution @zhuwenzhuang, I'll merge this if there is no objections from @chunweilei
libenchao
changed the title
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 11, 2022
…lterRule We now use RelBuilder#convert to make casts. This closes apache#2895
tanclary
pushed a commit
to tanclary/calcite
that referenced
this pull request
Nov 28, 2022
…lterRule We now use RelBuilder#convert to make casts. This closes apache#2895
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused variable 'newCasts' in AggregateCaseToFilter.