[CALCITE-5410] Assertion error on PERCENT_REMAINDER operator with DECIMAL type - #2993
Merged
Merged
Conversation
alex-plekhanov
force-pushed
the
calcite-5410
branch
from
December 1, 2022 08:33
293015c to
a5a7304
Compare
libenchao
approved these changes
Dec 3, 2022
libenchao
left a comment
libenchao
left a comment
Member
There was a problem hiding this comment.
+1, good catch, @alex-plekhanov thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PERCENT_REMAINDER operator should have the same return type inference as MOD operator.