[CALCITE-4698] Respect input types and precision for datetime_plus and timestampadd - #3104
Closed
snuyanzin wants to merge 7 commits into
Closed
[CALCITE-4698] Respect input types and precision for datetime_plus and timestampadd#3104snuyanzin wants to merge 7 commits into
snuyanzin wants to merge 7 commits into
Conversation
Contributor
|
Can you revert the changes in formatting? |
Contributor
Author
yeah, looks like i missed it, thanks |
Contributor
Author
|
Rebased to resolve conflicts |
|
Kudos, SonarCloud Quality Gate passed! |
snuyanzin
changed the title
julianhyde
added a commit
to julianhyde/calcite
that referenced
this pull request
Apr 28, 2023
Close apache#3104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR makes TimestampAddFunction respecting incoming type e.g.
timestamp with local time zoneand precision.