Minor: the parameter names of SqlTypeMappingRules.Builder#add are misleading#3308
Merged
libenchao merged 1 commit intoapache:mainfrom Aug 2, 2023
Merged
Minor: the parameter names of SqlTypeMappingRules.Builder#add are misleading#3308libenchao merged 1 commit intoapache:mainfrom
libenchao merged 1 commit intoapache:mainfrom
Conversation
chunweilei
reviewed
Jul 13, 2023
Contributor
chunweilei
left a comment
chunweilei
left a comment
There was a problem hiding this comment.
I think you're right. So I am +1 for this change. But the commit message should be more clear.
ForestLH
changed the title
Contributor
Author
Thank you reply :) |
Contributor
Author
|
Does anyone can review my code? |
Member
|
+1 too, and propose to rename the commit message to "Minor: the parameter names of SqlTypeMappingRules.Builder#add are misleading" |
…leading Signed-off-by: ForestLH <1838249551@qq.com>
ForestLH
changed the title
Contributor
Author
Thank you for your reply! |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of the parameter of this function is inconsistent with the actual meaning