Skip to content

Minor: the parameter names of SqlTypeMappingRules.Builder#add are misleading #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
libenchao merged 1 commit into from
Aug 2, 2023
Merged

Minor: the parameter names of SqlTypeMappingRules.Builder#add are misleading #3308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/java/org/apache/calcite/sql/type/SqlTypeMappingRules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ public static class Builder {
}

/** Add a map entry to the existing {@link Builder} mapping. */
void add(SqlTypeName fromType, Set<SqlTypeName> toTypes) {
void add(SqlTypeName toType, Set<SqlTypeName> fromTypes) {
try {
map.put(fromType, sets.get(toTypes));
map.put(toType, sets.get(fromTypes));
} catch (UncheckedExecutionException | ExecutionException e) {
throw Util.throwAsRuntime("populating SqlTypeAssignmentRules", Util.causeOrSelf(e));
}
Expand Down