[CALCITE-6618] Support NOT EQUALS operator in Arrow adapter - #3999
Merged
Conversation
Member
Author
|
This seems like a minor change😢, but I'm getting familiar with the module and I see there's still work to do. |
mihaibudiu
approved these changes
Oct 8, 2024
NobiGo
approved these changes
Oct 9, 2024
NobiGo
left a comment
NobiGo
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Only the Jira Summary needs to change.
caicancai
changed the title
caicancai
commented
Oct 11, 2024
| .explainContains(plan); | ||
| } | ||
|
|
||
| @Test void testArrowProjectFieldsWithBetweenFilter() { |
Member
Author
There was a problem hiding this comment.
I added a between test, it seems natively supported.
|
NobiGo
approved these changes
Oct 15, 2024
Member
Author
|
@mihaibudiu @NobiGo I see that the main branch can be merged. Is this PR easy to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-6618