[CALCITE-6737] LoptOptimizeJoinRule can not identify selfjoin on unique join keys - #4097
Merged
Merged
Conversation
kasakrisz
marked this pull request as draft
December 18, 2024 13:37
zabetak
approved these changes
Dec 18, 2024
zabetak
left a comment
zabetak
left a comment
Member
There was a problem hiding this comment.
LGTM! The CI failures seem unrelated. I will merge this once we get a green run.
Member
|
I was wrong the test failures are relevant. It seems that the commit message does not follow the style conventions. Let's fix it and trigger again the run. |
kasakrisz
force-pushed
the
CALCITE-6737-main-selfjoin
branch
from
December 18, 2024 14:59
a9663fc to
282db67
Compare
kasakrisz
changed the title
kasakrisz
marked this pull request as ready for review
December 18, 2024 14:59
|
Contributor
Author
|
Thanks for the review @zabetak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch restores the original behavior of {{LoptOptimizeJoinRule.java}} prior #2189