[CALCITE-6736] Validator accepts comparisons between arrays, multiset… - #4098
Merged
Conversation
…s, maps without regard to element types Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
ILuffZhe
approved these changes
Dec 19, 2024
ILuffZhe
left a comment
ILuffZhe
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, just one minor question.
| + "'<BINARY.2.> <> <INTEGER>'.*"); | ||
| // Test cases for [CALCITE-6736] Validator accepts comparisons between arrays, multisets, maps | ||
| // without regard to element types | ||
| expr("^array[x'a4'] = array[1]^") |
Contributor
There was a problem hiding this comment.
Do we need to add some positive tests for those types(like array[2]= array[1])?
Contributor
Author
There was a problem hiding this comment.
I assumed such tests exists, but didn't look too much. This change only rejects some programs that used to be accepted, so I really focused on negative tests.
NobiGo
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s, maps without regard to element types