[CALCITE-7575] Parser can not parse unparsed polymorphic table functions with several table args by snuyanzin · Pull Request #4984 · apache/calcite

snuyanzin · 2026-06-01T19:34:48Z

Jira Link

Changes Proposed

The PR is to support parsing of queries with PTF (polymorphic table functions) with several table args like

SELECT * FROM TABLE(MY_PTF(
(SELECT * FROM table1) PARTITION BY a,
(SELECT * FROM table2) PARTITION BY b))

mihaibudiu · 2026-06-01T19:58:59Z

        e = LambdaExpression()
    |
        e = Expression(exprContext)
+        // A set-semantics table argument may be a partitioned sub-query, e.g.


which part of the language reference does this correspond to?

this is SQL:2016 Polymorphic Table Functions (ISO/IEC 9075-2:2016)

the problem with current implementation is that it covers only first arg of table function and doesn't cover any other arg.

I mean, in the reference.md file

ah, then this line

calcite/site/_docs/reference.md

Lines 2208 to 2209 in 337abd4

* A polymorphic table function may have multiple input tables. However,

at most one input table could have row semantics.

I was looking for PARTITION BY in the grammar, but no place seemed to match what you are not parsing

yeah, seems it is missing details for PTF in reference.md
It was solved (for the first arg) in CALCITE-6944, also a number of references in this comment https://issues.apache.org/jira/browse/CALCITE-6944?focusedCommentId=17945242&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17945242
here I'm following the same approach for other(non-first) args

Can you then please update the grammar as well?

mihaibudiu · 2026-06-05T17:33:16Z

+A PTF may have more than one table argument, each with its own semantics,
+partitioning and ordering; at most one of them may have row semantics.
+
+| Operator syntax      | Description


Is a table needed for a single row?
Or is this for symmetry with other operators?

no, it is optional
here in reference just because of symmetry

sonarqubecloud · 2026-06-06T05:15:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…ons with several table args

snuyanzin · 2026-06-07T06:52:40Z

squashed and rebased before merging

mihaibudiu reviewed Jun 1, 2026

View reviewed changes

mihaibudiu approved these changes Jun 5, 2026

View reviewed changes

[CALCITE-7575] Parser can not parse unparsed polymorphic table functi…

8741cdc

…ons with several table args

snuyanzin force-pushed the calcite7575 branch from 67c7dd6 to 8741cdc Compare June 7, 2026 06:52

snuyanzin merged commit 8741cdc into apache:main Jun 7, 2026
17 of 18 checks passed

	* A polymorphic table function may have multiple input tables. However,
	at most one input table could have row semantics.

Uh oh!

Conversation

snuyanzin commented Jun 1, 2026

Jira Link

Changes Proposed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snuyanzin Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

snuyanzin Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 6, 2026

Quality Gate passed

Uh oh!

snuyanzin commented Jun 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

snuyanzin Jun 1, 2026 •

edited

Loading

snuyanzin Jun 1, 2026 •

edited

Loading