[CALCITE-2093, CALCITE-2088] More tests, removing locale dependent data from tests#600
Closed
ptrbojko wants to merge 4 commits into
Closed
[CALCITE-2093, CALCITE-2088] More tests, removing locale dependent data from tests#600ptrbojko wants to merge 4 commits into
ptrbojko wants to merge 4 commits into
Conversation
vlsi
requested changes
Jan 10, 2018
vlsi
left a comment
vlsi
left a comment
Contributor
There was a problem hiding this comment.
It looks like you are adding tests to src/main/...
plus/src/main/resources/chinook/database.sql
Would you please consider moving that (test code and resources) to src/tests/...?
| <version>${hsqldb.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.hsqldb</groupId> |
Contributor
There was a problem hiding this comment.
Would you please use spaces instead of tabs for indentation like used in the file?
| <artifactId>quidem</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.commons</groupId> |
Author
|
Travis fails because https://github.com/julianhyde/chinook-data-hsqldb is not in Maven Central. |
added 4 commits
February 21, 2018 23:16
[CALCITE-2088] Chinook database with simple end to end tests of calcite jdbc Additional changes: - Hinting gititgnore to ignore netbeans project config overrides
7mming7
pushed a commit
to Kyligence/calcite
that referenced
this pull request
Jan 23, 2021
…ite JDBC (Piotr Bojko) Tests use the chinook-data-hsqldb data set from maven central. Fix bug, introduced in [CALCITE-2128], where JdbcJoinRule is erroneously applied to SemiJoin. In gitignore, ignore netbeans project config overrides. Close apache#600
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional changes: