virts-2891 - Planner parsing error checking#2275
Merged
Merged
Conversation
added 2 commits
September 21, 2021 17:15
failed based on the output of the parser
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #2275 +/- ##
==========================================
- Coverage 72.27% 72.14% -0.14%
==========================================
Files 105 106 +1
Lines 7748 7790 +42
==========================================
+ Hits 5600 5620 +20
- Misses 2148 2170 +22
Continue to review full report at Codecov.
|
mkultraWasHere
approved these changes
Sep 23, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This change makes it possible for parsers to return an error code that signals the failure of a link based on the return, regardless of the return code of the link. This functionality is not automatic, and needs to be manually triggered from parsers to occur. For an example, see the atomic example.
Type of change
How Has This Been Tested?
This has been tested in a AWS environment with Alice 2.0, as well as with the full battery of tests.
Checklist: