Skip to content

virts-2891 - Powershell error parsing#27

Merged
ArtificialErmine merged 4 commits into
masterfrom
virts-2891
Oct 6, 2021
Merged

virts-2891 - Powershell error parsing#27
ArtificialErmine merged 4 commits into
masterfrom
virts-2891

Conversation

@ArtificialErmine
Copy link
Copy Markdown
Contributor

@ArtificialErmine ArtificialErmine commented Sep 22, 2021

Description

These changes make it possible for Caldera to parse powershell script returns from powershell abilities in Atomic to determine if they encountered an error. If an error was encountered, the link will be marked as unsuccessful. Requires associated CORE changes.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This has been tested in a AWS environment with Alice 2.0, as well as with the full battery of tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [NA] I have made corresponding changes to the documentation
  • [NA] I have added tests that prove my fix is effective or that my feature works

Comment thread app/parsers/powershell.py Outdated
mkultraWasHere
mkultraWasHere previously approved these changes Sep 23, 2021
Copy link
Copy Markdown
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these powershell errors specific to Atomic or would this parser be useful for all powershell abilities?

Comment thread app/parsers/powershell.py
Comment thread app/atomic_svc.py
@mkultraWasHere
Copy link
Copy Markdown
Contributor

@ArtificialErmine - it can be merged right? (2 reviews for plugins)

@ArtificialErmine
Copy link
Copy Markdown
Contributor Author

@ArtificialErmine - it can be merged right? (2 reviews for plugins)

Yep, but I'm holding off until 4.0 ships.

@ArtificialErmine ArtificialErmine merged commit e45e2ab into master Oct 6, 2021
@clenk clenk deleted the virts-2891 branch October 7, 2021 12:14
soumaiab pushed a commit to CIISE2022/atomic that referenced this pull request Sep 12, 2025
virts-2891 - Powershell error parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants