Fix observation example: drop hardcoded micrometer-tracing-bom import - #203
Merged
Merged
Conversation
observation/pom.xml imported micrometer-tracing-bom 1.5.0 ahead of spring-boot-dependencies (which manages 1.7.1), forcing micrometer-core down to 1.15.0. That version is missing the JvmMemoryMeterConventions class, so service2 crashed at startup with a ClassNotFoundException before service1/client could even be reached. spring-boot-dependencies already manages micrometer-tracing consistently, so the extra BOM import is removed instead of pinned to a matching version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JvQJNT1UYzqUm5HQtkL6Nu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
observation/pom.xmlimportedmicrometer-tracing-bom:1.5.0ahead ofspring-boot-dependencies(which manages 1.7.1), forcingmicrometer-coredown to 1.15.0JvmMemoryMeterConventionsclass, soservice2crashed at startup with aClassNotFoundException(beforeservice1/clientcould even be reached)micrometer-tracing.versionproperty and BOM import, lettingspring-boot-dependenciesmanagemicrometer-tracing/micrometer-coreconsistentlyTest plan
mvn dependency:tree -Dincludes=io.micrometer:micrometer-coreonservice2now resolves1.17.1(fromspring-boot-dependencies) instead of1.15.0JvmMemoryMeterConventionsis present in the resolvedmicrometer-core:1.17.1jarloggingtracer,client,service1,service2) succeedsservice2withspring-boot:run— starts cleanly (Started Service2Application in 1.483 seconds), noClassNotFoundException