Fix platform-http example README and indentation - #204
Open
Croway wants to merge 1 commit into
Open
Conversation
The README incorrectly stated the example uses camel-servlet-starter as the platform-http-engine implementation; the pom has no such dependency, it actually runs via spring-boot-starter-webmvc/Tomcat with camel-platform-http-starter. Also refreshed the stale sample log (Spring Boot 3.4.5 -> 4.1.1, Tomcat 10.1.40 -> 11.0.24) with real output from a fresh run, and normalized tab/space indentation to match the repo's 4-space convention. All CRUD endpoints verified working against a live run. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HseDjsECuZhsCXxxioiD1k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
camel-servlet-starteras the platform-http-engine implementation. The pom has no such dependency — it actually runs viaspring-boot-starter-webmvc/Tomcat withcamel-platform-http-starter. Corrected the description.CamelRouter.java,Todo.java,TodoService.java, andTodoServiceImpl.javato the repo's 4-space convention.Test plan
mvn packagebuilds cleanlymvn spring-boot:runand exercised all CRUD endpoints (POST, GET all, GET by id, PATCH, DELETE completed, DELETE by id) — all work as documentedcamel-spring-bootstarter docs/tests thatcamel-platform-http-starter+spring-boot-starter-webmvc(notcamel-servlet-starter) is the actual engine implementation