Skip to content

Made the logo shorter in shorter resolutions of screen - #192

Closed
PrernaSingh587 wants to merge 2 commits into
apache:masterfrom
PrernaSingh587:psingh587-logo-d
Closed

Made the logo shorter in shorter resolutions of screen#192
PrernaSingh587 wants to merge 2 commits into
apache:masterfrom
PrernaSingh587:psingh587-logo-d

Conversation

@PrernaSingh587

Copy link
Copy Markdown
Contributor

WhatsApp Video 2020-03-11 at 18 41 48

After the change.

I have changed the logo to just camel when screen size reduces, though a lot more changes need to be done regarding the search bar overlapping it. but please review this one.
@PrernaSingh587

Copy link
Copy Markdown
Contributor Author

@zregvart
Here's my take on it, Sir.
The bigger logo which is there right now gets hidden behind the search bar, so i tried to making the logo itself smaller. We can keep both the logo(smaller one ) and search box together for smaller resolutions this way ( ~ 471px being the smallest after which the logo starts to hide, in that case we can try something else ).

@CSElonewolf

Copy link
Copy Markdown
Contributor

This is better idea @psingh587 .
@zregvart and @oscerd please have a look and let me know whether I should proceed with the issue #191 or not.

@zregvart

Copy link
Copy Markdown
Member

Preview is here.

Nice work @psingh587, I think this is much better than what we have. I'm worried a bit about even smaller widths, I usually test with 360 and 411 widths in Firefox this profile is called "Galaxy S9/S9+ Android 7.0" and "Pixel 2 Android 8.0". It's not as nice with those.

I'm not sure what is the smallest width that we should support, so it might be fine regardless.

My opinion, and I don't have to be right, is that perhaps a combined approach with ideas from both @CSElonewolf and @psingh587 could be the winner here. Idea of putting the search in the menu is very interesting to me. In the long run I'd like the menu on smaller screens to take up the full width of the screen, that way we can increase the spacing and have larger touch targets.

@PrernaSingh587

Copy link
Copy Markdown
Contributor Author

@zregvart
Thank you sir for your feedback.
I myself think that the idea of putting the search bar in the menu is quite nice. We can do that for resolutions below 471. But beyond 471 and till 1023 px widths i think this looks good with a smaller logo and search bar together

@CSElonewolf

Copy link
Copy Markdown
Contributor

Screenshot_2020-03-11-20-12-31-108_com android chrome

This is how the preview looks in my smartphone. :( issue remains.
But not to worry.Well then let me go ahead with modifying my own #191 . @zregvart
Hopefully will submit a new commit today itself.

@PrernaSingh587

PrernaSingh587 commented Mar 11, 2020

Copy link
Copy Markdown
Contributor Author

Screenshot_2020-03-11-20-12-31-108_com android chrome

This is how the preview looks in my smartphone. :( issue remains.
But not to worry.Well then let me go ahead with modifying my own #191 . @zregvart
Hopefully will submit a new commit today itself.

Yes.. I have not made the changes for smaller screen width below 471.

  • ( ~ 471px being the smallest after which the logo starts to hide, in that case we can try something else ).* --(as i said in my first comment)

I think you can go with putting search bar in menu for it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants