Improvement upon the navbar-menu - #196
Merged
Merged
Conversation
oscerd
approved these changes
Mar 11, 2020
Contributor
Author
|
the second commit does something like this --the color is same as what the navbar items in bigger resolution have, also the dropdown list items have underline hover property . |
Contributor
Author
zregvart
approved these changes
Mar 12, 2020
zregvart
left a comment
zregvart
left a comment
Member
There was a problem hiding this comment.
Preview is here.
I'm a bit weary of introducing new media selectors, if we do so then we have to make sure that the rest of the website also adheres to these. This targets just the navbar so that might be okay.
I like the right aligning the menu and making the sections with distinct colour and font weight.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is regarding the merged PR #194
I have tried making some amendments to it
@zregvart @oscerd Please check it.
This is how the navbar-menu covers the whole space on 1023px. What I feel is that it is not neccessary to have it cover the entire window here.
this is my version (when width is 1023px)
and also i think in smaller resolutions it can cover the entire screen so here's my take on it..
