Skip to content

Handle quote escape in bindy - #13270

Merged
davsclaus merged 2 commits into
apache:mainfrom
Croway:bindy-handle-escape
Feb 28, 2024
Merged

Handle quote escape in bindy#13270
davsclaus merged 2 commits into
apache:mainfrom
Croway:bindy-handle-escape

Conversation

@Croway

@Croway Croway commented Feb 22, 2024

Copy link
Copy Markdown
Contributor

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus

Copy link
Copy Markdown
Contributor

Nice magic with the scanner.

We have StringQuoteHelper for safe splitting when using quotes as double or single quote chars. But I guess the scanner and bindy can in theory use other quote chars - but who would not use " ?

@davsclaus

Copy link
Copy Markdown
Contributor

is there more work needed for this PR or can it be ready for review and merge ?

@Croway
Croway marked this pull request as ready for review February 27, 2024 11:14
@Croway

Croway commented Feb 27, 2024

Copy link
Copy Markdown
Contributor Author

I'll come up with more tests, but can be merged at the moment

@davsclaus

Copy link
Copy Markdown
Contributor

If we need to backport this, then its good to have a JIRA ticket for this to track this

@davsclaus
davsclaus merged commit a231247 into apache:main Feb 28, 2024
davsclaus added a commit that referenced this pull request Feb 28, 2024
davsclaus pushed a commit that referenced this pull request Feb 28, 2024
* Handle quote escape in bindy

* Handle quote escape in bindy
davsclaus added a commit that referenced this pull request Feb 28, 2024
davsclaus pushed a commit that referenced this pull request Feb 28, 2024
* Handle quote escape in bindy

* Handle quote escape in bindy
davsclaus added a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants