CAMEL-23274: Fix SonarCloud critical bugs in test code#22478
Merged
gnodet merged 1 commit intoapache:mainfrom Apr 8, 2026
Merged
CAMEL-23274: Fix SonarCloud critical bugs in test code#22478gnodet merged 1 commit intoapache:mainfrom
gnodet merged 1 commit intoapache:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CAMEL-23274
Fix two critical SonarCloud bugs reported on the
mainbranch:ModelParserTest.java (S5783): Extract
ModelParserconstruction out of theassertThrowslambda so that onlyparseRoutesDefinition()is the throwing call. Previously both the constructor and the method could throw the same checked exception, making it ambiguous which call caused the exception.EnvironmentHelperTest.java (S5845): Replace
assertNotNull(result)withassertDoesNotThrow(...)for three tests whereresultis a primitiveboolean. Comparing a primitive withnullviaassertNotNullis always true due to autoboxing and does not test anything meaningful.