Skip to content

CAMEL-23274: Fix SonarCloud critical bugs in test code #22478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 1 commit into from
Apr 8, 2026
Merged

CAMEL-23274: Fix SonarCloud critical bugs in test code #22478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/camel-xml-io/src/test/java/org/apache/camel/xml/in/ModelParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,9 @@ public void testMethodAfterStepsInWhenClauseShouldFail() throws Exception {
</route>
</routes>
""";
ModelParser parser = new ModelParser(new StringReader(routesXml));
Exception e = assertThrows(Exception.class, () -> {
new ModelParser(new StringReader(routesXml)).parseRoutesDefinition();
parser.parseRoutesDefinition();
});
assertThat(e).hasStackTraceContaining("already has a predicate");
}
Expand Down
11 changes: 4 additions & 7 deletions ...bang-core/src/test/java/org/apache/camel/dsl/jbang/core/common/EnvironmentHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

class EnvironmentHelperTest {
Expand All @@ -28,20 +28,17 @@ class EnvironmentHelperTest {
void testIsColorEnabledReturnsBoolean() {
// Should not throw and should return a boolean value
// The actual result depends on the environment, but the method should work
boolean result = EnvironmentHelper.isColorEnabled();
assertNotNull(result);
assertDoesNotThrow(() -> EnvironmentHelper.isColorEnabled());
}

@Test
void testIsCIEnvironmentReturnsBoolean() {
boolean result = EnvironmentHelper.isCIEnvironment();
assertNotNull(result);
assertDoesNotThrow(() -> EnvironmentHelper.isCIEnvironment());
}

@Test
void testIsInteractiveTerminalReturnsBoolean() {
boolean result = EnvironmentHelper.isInteractiveTerminal();
assertNotNull(result);
assertDoesNotThrow(() -> EnvironmentHelper.isInteractiveTerminal());
}

@Test
Expand Down
Loading