[backport camel-4.18.x] CAMEL-23585: camel-arangodb - align Exchange header constant names with Camel naming convention#23527
Open
oscerd wants to merge 1 commit into
Conversation
davsclaus
approved these changes
May 26, 2026
gnodet
approved these changes
May 26, 2026
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Clean backport of the camel-arangodb header rename to 4.18.x. Consistent with the header-naming convention work. Upgrade guide entry included.
LGTM.
Fully automatic review from Claude Code
…th Camel naming convention (apache#23469) Renames the two Exchange header string values in ArangoDbConstants that were not in the Camel namespace (key, ResultClassType) to CamelArangoDb<Name>, following the convention used across the rest of the Camel component catalog and matching the pattern established in CAMEL-23526 (camel-cxf), CAMEL-23522 (camel-mail), CAMEL-23461 (camel-aws-bedrock), CAMEL-23532 (camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy), and CAMEL-23576 (camel-jira). - ARANGO_KEY: "key" -> "CamelArangoDbKey" - RESULT_CLASS_TYPE: "ResultClassType" -> "CamelArangoDbResultClassType" The Java field names are unchanged so routes referencing the constants symbolically continue to work; routes using the literal string values must be updated (documented in the 4.21 upgrade guide). The remaining constants (MULTI_UPDATE, MULTI_INSERT, MULTI_DELETE, AQL_QUERY, AQL_QUERY_BIND_PARAMETERS, AQL_QUERY_OPTIONS) were already Camel-prefixed and are unchanged. The generated Endpoint DSL header accessors on ArangoDbHeaderNameBuilder have been renamed: key() -> arangoDbKey() and resultClassType() -> arangoDbResultClassType(). All existing tests use symbolic constant references and continue to pass. Tracker: CAMEL-23577 Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
oscerd
force-pushed
the
backport/23469-to-camel-4.18.x
branch
from
41fa93c to
0363bfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #23469 to
camel-4.18.x.Cherry-pick of merge commit
2371b7fd582with one adaptation: the originalPR's upgrade-guide entry was added to
camel-4x-upgrade-guide-4_21.adoc,which does not exist on the 4.18.x maintenance branch. Per the project's
backport policy the same content has been added to
camel-4x-upgrade-guide-4_18.adocinstead.Summary
Renames the two Exchange header string values in
ArangoDbConstantsthat werenot in the
Camelnamespace (and therefore not filtered by the defaultHeaderFilterStrategy) toCamelArangoDb<Name>:ArangoDbConstants.ARANGO_KEYkeyCamelArangoDbKeyArangoDbConstants.RESULT_CLASS_TYPEResultClassTypeCamelArangoDbResultClassTypeThe Java field names are unchanged so routes referencing the constants
symbolically continue to work; routes using the literal string values must be
updated.
MULTI_UPDATE,MULTI_INSERT,MULTI_DELETE,AQL_QUERY,AQL_QUERY_BIND_PARAMETERS,AQL_QUERY_OPTIONSwere alreadyCamel-prefixedand are unchanged.
DSL accessor renames:
key()→arangoDbKey(),resultClassType()→arangoDbResultClassType().Test plan
mvn testincomponents/camel-arangodbon the 4.18.x branch — passesrename described above (no merge marker shipped)
=== camel-arangodb - potential breaking changeincamel-4x-upgrade-guide-4_18.adoc, immediatelybefore the existing
=== camel-web3jbackport entryTracker: CAMEL-23577
Reported by Claude Code on behalf of Andrea Cosentino