[backport camel-4.18.x] CAMEL-23583: camel-google-functions + camel-google-secret-manager - align Exchange header constant names with Camel naming convention#23539
Open
oscerd wants to merge 1 commit into
Conversation
davsclaus
approved these changes
May 26, 2026
gnodet
approved these changes
May 26, 2026
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Standard header rename backport for camel-google-functions and camel-google-secret-manager to 4.18.x. Renames headers like GoogleCloudFunctionsOperation → CamelGoogleCloudFunctionsOperation and GoogleSecretManagerOperation → CamelGoogleSecretManagerOperation. Follows the established Camel header naming convention. Upgrade guide entry included.
LGTM.
Fully automatic review from Claude Code
…eech,speech-to-text} - align Exchange header constant names with Camel naming convention (apache#23467) Renames the Exchange header string values in the Google Cloud component constants from their GoogleCloud<Service> / GoogleSecretManager prefixes (which are outside the Camel namespace and therefore not filtered by the default HeaderFilterStrategy) to CamelGoogle<Service><Name>, following the convention used across the rest of the Camel component catalog and matching the pattern established in CAMEL-23526 (camel-cxf), CAMEL-23522 (camel-mail), CAMEL-23461 (camel-aws-bedrock), CAMEL-23532 (camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy), and CAMEL-23576 (camel-jira). Renamed values: - GoogleCloudFunctions: OPERATION, ENTRY_POINT, RUNTIME, SOURCE_ARCHIVE_URL, RESPONSE_OBJECT - GoogleSecretManager: OPERATION (SECRET_ID, VERSION_ID, REPLICATION were already Camel-prefixed) - GoogleCloudVision: OPERATION, RESPONSE_OBJECT - GoogleCloudTextToSpeech: OPERATION, RESPONSE_OBJECT - GoogleCloudSpeechToText: OPERATION, RESPONSE_OBJECT The Java field names are unchanged so routes referencing the constants symbolically continue to work; routes using the literal string values must be updated (documented in the 4.21 upgrade guide). The generated Endpoint DSL header accessor names are unchanged (the Camel prefix is stripped when deriving the accessor name); the accessors now return the new values. All existing tests use symbolic constant references and continue to pass. Tracker: CAMEL-23577 Reported by Claude Code on behalf of Andrea Cosentino Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
oscerd
force-pushed
the
backport/23467-to-camel-4.18.x
branch
from
b22ede7 to
df87c78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the camel-google-functions and camel-google-secret-manager
portions of #23467 to
camel-4.18.x. The original PR also renamedcamel-google-vision,camel-google-text-to-speechandcamel-google-speech-to-text, but those components were added after the4.18.x branch point and do not exist on this maintenance branch, so the
backport is intentionally scoped down to the two components that DO exist.
Cherry-pick of merge commit
3addcc5d10awith two adaptations:camel-4x-upgrade-guide-4_21.adoc, which does not exist on 4.18.x. Perthe project's backport policy the same content (scoped to the two
surviving components) has been added to
camel-4x-upgrade-guide-4_18.adocinstead.cherry-pick were
git rm-ed because the components do not exist on4.18.x.
Summary
Renames the Exchange header string values in
GoogleCloudFunctionsConstantsand
GoogleSecretManagerConstantsthat had aGoogleCloud<Service>/GoogleSecretManagerprefix toCamelGoogle<Service><Name>so they sitinside the
Camelnamespace filtered by the defaultHeaderFilterStrategy.GoogleCloudFunctionsConstants.OPERATIONGoogleCloudFunctionsOperationCamelGoogleCloudFunctionsOperationGoogleCloudFunctionsConstants.ENTRY_POINTGoogleCloudFunctionsEntryPointCamelGoogleCloudFunctionsEntryPointGoogleCloudFunctionsConstants.RUNTIMEGoogleCloudFunctionsRuntimeCamelGoogleCloudFunctionsRuntimeGoogleCloudFunctionsConstants.SOURCE_ARCHIVE_URLGoogleCloudFunctionsSourceArchiveUrlCamelGoogleCloudFunctionsSourceArchiveUrlGoogleCloudFunctionsConstants.RESPONSE_OBJECTGoogleCloudFunctionsResponseObjectCamelGoogleCloudFunctionsResponseObjectGoogleSecretManagerConstants.OPERATIONGoogleSecretManagerOperationCamelGoogleSecretManagerOperationGoogleSecretManagerConstants.SECRET_ID,VERSION_IDandREPLICATIONwerealready
Camel-prefixed and are unchanged.DSL accessor names unchanged (e.g.
googleCloudFunctionsOperation()); theynow return the new
Camel-prefixed values.Test plan
mvn testincomponents/camel-google/camel-google-functionson4.18.x — BUILD SUCCESS
mvn testincomponents/camel-google/camel-google-secret-manageron4.18.x — BUILD SUCCESS
marker shipped)
=== camel-google-functions / camel-google-secret-manager - potential breaking changeincamel-4x-upgrade-guide-4_18.adoc, with anexplicit NOTE that vision/tts/stt are not backported
Tracker: CAMEL-23577
Reported by Claude Code on behalf of Andrea Cosentino