CAMEL-23223: Stabilize flaky ManagedMessageHistoryAutoConfigIT

[gnodet]

Summary

Fixes the intermittent failure of ManagedMessageHistoryAutoConfigIT.testMessageHistory in camel-opentelemetry-metrics, reported across various CI architectures.

Root cause: The test used await().atMost(1000ms).until(handler::hasLogs) which only waited for any log to appear (which could be a non-Camel OTel internal metric), then immediately asserted on all metrics. On slow CI architectures (ppc64le, s390x), the Camel-specific metrics may not have been exported yet within 1 second. Additionally, early metric exports during message processing could contain incomplete data, causing the per-entry assertions to fail.

Fix:

• Replace the two-step approach (wait for any log → assert immediately) with await().atMost(20s).untilAsserted(...) that retries the full set of metric assertions until the OTel periodic reader exports Camel metrics
• Assert on the last exported Camel MetricData (which contains the complete accumulated histogram data), rather than asserting on every exported entry
• Make MemoryLogHandler thread-safe with CopyOnWriteArrayList since publish() is called from the OTel exporter thread while getLogs()/hasLogs() are called from the test thread
• Remove handler from logger in finally block to prevent handler accumulation across test runs in the same JVM
• Remove redundant new ArrayList<>() wrapper since getLogs() already returns a defensive copy

Test plan

• ManagedMessageHistoryAutoConfigIT passes consistently (verified 3 consecutive runs locally)
• All 89 unit tests + integration tests pass in the module
• CI passes on all architectures

Claude Code on behalf of @davsclaus

🤖 Generated with Claude Code

[github-actions]

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

• First-time contributors require MANUAL approval for the GitHub Actions to run
• You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
• You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
• Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

[github-actions]

🧪 CI tested the following changed modules:

• components/camel-opentelemetry-metrics

---

🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 9 all tested

Maveniverse Scalpel detected 1 affected modules (current approach: 9).

Modules only in current approach (8)

• camel-jbang-mcp
• camel-jbang-plugin-mcp
• camel-jbang-plugin-route-parser
• camel-jbang-plugin-tui
• camel-jbang-plugin-validate
• camel-launcher-container
• camel-yaml-dsl-validator
• camel-yaml-dsl-validator-maven-plugin

Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules)

Modules Scalpel would test (1)

• camel-opentelemetry-metrics

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (9 modules)

• Camel :: JBang :: MCP
• Camel :: JBang :: Plugin :: MCP
• Camel :: JBang :: Plugin :: Route Parser
• Camel :: JBang :: Plugin :: TUI
• Camel :: JBang :: Plugin :: Validate
• Camel :: Launcher :: Container
• Camel :: Opentelemetry Metrics
• Camel :: YAML DSL :: Validator
• Camel :: YAML DSL :: Validator Maven Plugin

---

⚙️ View full build and test results

[Copilot]

Pull request overview

Stabilizes the ManagedMessageHistoryAutoConfigIT.testMessageHistory integration test in camel-opentelemetry-metrics by making metric assertions resilient to delayed/partial OpenTelemetry periodic exports and by hardening the in-memory log capture against concurrent access.

Changes:

• Replaces “wait for any export → assert once” with an await().untilAsserted(...) loop that retries the full metric assertions until Camel metrics are available and complete.
• Asserts against the last exported Camel MetricData rather than every exported entry to avoid transient/incomplete exports during message processing.
• Makes MemoryLogHandler thread-safe by using CopyOnWriteArrayList for cross-thread log publishing/reading.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
components/camel-opentelemetry-metrics/src/test/java/org/apache/camel/opentelemetry/metrics/integration/messagehistory/ManagedMessageHistoryAutoConfigIT.java	Reworks the Awaitility strategy and assertion target to reduce flakiness on slower CI architectures.
components/camel-opentelemetry-metrics/src/test/java/org/apache/camel/opentelemetry/metrics/integration/MemoryLogHandler.java	Switches log storage to a thread-safe list to avoid races between exporter and test threads.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gnodet]

Addressed both points in c26c8fe:

• Added logger.removeHandler(handler) in a finally block to prevent handler accumulation.
• Removed the redundant new ArrayList<>() wrapper (and the now-unused ArrayList import) since getLogs() already returns a defensive copy.