Skip to content

chore: Fix uncommitted formatter changes breaking CI on all PRs#24466

Merged
davsclaus merged 1 commit into
mainfrom
ci-is-failing-on-all-prs-due-to-uncommitted-format
Jul 6, 2026
Merged

chore: Fix uncommitted formatter changes breaking CI on all PRs#24466
davsclaus merged 1 commit into
mainfrom
ci-is-failing-on-all-prs-due-to-uncommitted-format

Conversation

@gnodet

@gnodet gnodet commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Commit cdaf5a8 (CAMEL-19807) introduced Javadoc line wrapping and string concatenation alignment in BeansDefinition.java and XmlRoutesBuilderLoader.java that don't match what mvn formatter:format produces.
  • The CI step "Fail if there are uncommitted changes" detects these differences after the build runs the formatter, causing all PR builds to fail regardless of what the PR changes.
  • This PR runs mvn formatter:format impsort:sort on the two affected modules to align the committed code with the project's formatting rules.

Changes

BeansDefinition.java — Javadoc @deprecated tag line wrapping (2 occurrences):

-     * @deprecated use standard Camel XML DSL (camel-xml-io) instead of legacy Spring/Blueprint XML.
-     *             This feature will be removed in a future release.
+     * @deprecated use standard Camel XML DSL (camel-xml-io) instead of legacy Spring/Blueprint XML. This feature will
+     *             be removed in a future release.

XmlRoutesBuilderLoader.java — String concatenation + alignment:

-                                + " Migrate to standard Camel XML DSL (camel-xml-io).");
+                         + " Migrate to standard Camel XML DSL (camel-xml-io).");

Test plan

  • Verified the exact same diff appears in CI logs of failing PRs (e.g. PR #24462 build log)
  • Ran mvn formatter:format impsort:sort locally and confirmed git status is clean after
  • CI build on this PR should pass the "Fail if there are uncommitted changes" step

Claude Code on behalf of @aldettinger

🤖 Generated with Claude Code

Commit cdaf5a8 (CAMEL-19807) introduced Javadoc and string
concatenation formatting that differs from what the project formatter
produces. The CI step "Fail if there are uncommitted changes" detects
these differences after running the formatter, causing all PR builds
to fail.

Run `mvn formatter:format impsort:sort` on the two affected modules
to align the code with the project's formatting rules.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus davsclaus merged commit 5a555b7 into main Jul 6, 2026
3 of 5 checks passed
@apupier apupier deleted the ci-is-failing-on-all-prs-due-to-uncommitted-format branch July 6, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants