CAMEL-23877: Fix camel-pinecone tls option documented default and add insecure:ssl annotation#24661
Merged
Conversation
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
approved these changes
Jul 13, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Claude Code review on behalf of @gnodet
Clean, well-scoped fix. I verified the following:
-
Default value mismatch confirmed: The Java field
private boolean tls;(a primitive boolean) defaults tofalse, but@UriParam(defaultValue = "true")documented it astrue. The PR correctly aligns the annotation with the runtime default. The existing test atPineconeComponentConfigurationTest.java:65already assertsassertEquals(false, endpoint.getConfiguration().isTls()), which confirms the runtime default was alwaysfalse. -
Security annotation correct:
security = "insecure:ssl"withinsecureValue = "false"is the correct pattern for a TLS-enable option where disabling it (setting tofalse) is insecure. This matches the convention used byhostnameverification,validatecertificates,verifyssl, etc. inSecurityUtils. -
Code simplification sound: Changing from conditional
if (!tls) { builder.withTlsEnabled(tls); }to unconditionalbuilder.withTlsEnabled(configuration.isTls())is cleaner and explicitly communicates the TLS setting to the Pinecone SDK in both directions. -
SecurityUtils entry: The
"tls"entry is correctly placed alphabetically and usesVALUE_FALSE. Note that this will also apply to other components with atlsoption (Qdrant, MongoDB) which have the same semantics -- this is a net positive for security coverage. -
Upgrade guide: Properly documents this as a documentation-only correction with no behavioral change.
No issues found. LGTM.
Scanner coverage: No static analysis tools ran (Maven build not executed in this review). No SonarCloud, SpotBugs, or Error Prone output available. This review is based on manual code inspection of the diff, git history, and cross-referencing with project conventions.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 562 tested, 25 compile-only — current: 558 all testedMaveniverse Scalpel detected 587 affected modules (current approach: 558).
|
… insecure:ssl annotation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
davsclaus
force-pushed
the
fix/CAMEL-23877
branch
from
fecf256 to
b90ff37
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude Code on behalf of davsclaus
tlsoption's@UriParam(defaultValue)from"true"to"false"to match the actual Java field defaultsecurity = "insecure:ssl"andinsecureValue = "false"annotations to flag TLS-disabled as an insecure configurationPineconeVectorDbEndpoint.createClient()to always pass the configured value to the Pinecone SDK builderNo behavioral change — the runtime default was already
false.Test plan
mvn testpasses incomponents/camel-ai/camel-pinecone(2/2 tests)pinecone.json) shows"defaultValue": falsewith"security": "insecure:ssl"🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com