CAMEL-24114: camel-rest-openapi - Request validator also checks exchange variables and endpoint literal parameters#24806
Merged
Merged
Conversation
…nge variables and endpoint literal parameters for required query parameters Signed-off-by: Claus Ibsen <davsclaus@apache.org> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
gnodet
approved these changes
Jul 16, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
LGTM — clean, well-scoped fix.
The fallback chain (header → exchange variable → endpoint literal parameter) correctly mirrors
the resolution order in RestProducer.createQueryParameters(), so the validator now accepts
required query parameters regardless of how they are supplied.
Verified:
parametersfield inRestOpenApiEndpointholds the literal URI parameters (e.g.status=available)- Null-safe:
setEndpointParametersdefaults toCollections.emptyMap() - Non-query params like
requestValidationEnabledwon't false-positive since the validator only
checks names that match the OpenAPI operation's required query parameters - Both new test scenarios (endpoint URI literal + exchange variable) cover the two new resolution paths
Claude Code on behalf of gnodet
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 18 tested, 29 compile-only — current: 18 all testedMaveniverse Scalpel detected 47 affected modules (current approach: 18).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultRequestValidatorrejected requests whose required query parameters were supplied via endpoint URI literals or exchange variables, because it only checkedmessage.getHeader().The fix extends the query parameter validation in
DefaultRequestValidator.validate()to mirror the resolution order used byRestProducer.createQueryParameters():Changes:
DefaultRequestValidator— addedendpointParametersfield and extended the required query parameter check to also consult exchange variables and endpoint literal parametersRestOpenApiEndpoint.configureRequestValidator()— passes the endpoint's remaining parameters to the validatorRestOpenApiRequestValidationTest— added two new parameterized tests covering literal endpoint URI query params and exchange variables with validation enabledFixes: CAMEL-24114
Claude Code on behalf of davsclaus
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com