[backport camel-4.14.x] CAMEL-24191: camel-aws2-kinesis - fix KCL consumer session credentials and checkpoint/error handling#24849
Merged
Conversation
…s and checkpoint/error handling (apache#24835) Reorder credential branches so session tokens are used (both DynamoDB and CloudWatch builders); checkpoint only after a successful batch and route processing failures to the ExceptionHandler without checkpointing so KCL redelivers. Adds KclKinesis2ConsumerRecordProcessingTest. Related to CAMEL-24156. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
gnodet
approved these changes
Jul 17, 2026
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Claude Code on behalf of gnodet
LGTM — clean backport of #24835 to camel-4.14.x.
Verified the diff is identical to the original PR:
- Session credential branch reordering — 3-param check (accessKey + secretKey + sessionToken) now precedes 2-param check, for both DynamoDB and CloudWatch async clients
- processRecords checkpoint fix — checkpoint only after successful batch processing; failures routed to ExceptionHandler without checkpointing (at-least-once delivery)
- Test —
KclKinesis2ConsumerRecordProcessingTestverifying checkpoint-on-success / no-checkpoint-on-failure semantics
CI pending — will pass based on the identical change passing on main.
davsclaus
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24835 to
camel-4.14.x. Fixes CAMEL-24191 on the 4.14.x line: reorder the DynamoDB/CloudWatch credential branches so session tokens are used, and make the KCLprocessRecordscheckpoint only after a successful batch (routing failures to the ExceptionHandler without checkpointing, so KCL redelivers). IncludesKclKinesis2ConsumerRecordProcessingTest. Related to CAMEL-24156.Claude Code on behalf of oscerd