Skip to content

CAMEL-21933: camel-aws2-eventbridge - re-enable PutRule, PutEvents and RemoveTargets localstack ITs - #25053

Merged
oscerd merged 1 commit into
apache:mainfrom
oscerd:fix/CAMEL-21933
Jul 23, 2026
Merged

CAMEL-21933: camel-aws2-eventbridge - re-enable PutRule, PutEvents and RemoveTargets localstack ITs#25053
oscerd merged 1 commit into
apache:mainfrom
oscerd:fix/CAMEL-21933

Conversation

@oscerd

@oscerd oscerd commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Motivation

CAMEL-21933. EventbridgePutRuleIT, EventbridgePutEventsIT and EventbridgeRemoveTargetsIT were disabled with "Doesn't work with Localstack v4".

They now pass against the LocalStack image the AWS test-infra currently uses (mirror.gcr.io/floci/floci:1.5.28), so the upstream behaviour that broke them has since been fixed.

Changes

Remove the @Disabled("Doesn't work with Localstack v4") annotation (and the now-unused org.junit.jupiter.api.Disabled import) from the three ITs. Test-only change.

Testing

Ran all three against LocalStack via the AWS test-infra:

EventbridgePutRuleIT       Tests run: 1, Failures: 0, Errors: 0
EventbridgePutEventsIT     Tests run: 1, Failures: 0, Errors: 0
EventbridgeRemoveTargetsIT Tests run: 1, Failures: 0, Errors: 0

Plus the module's 25 unit tests pass, and a full reactor mvn clean install -DskipTests from root succeeds.

Claude Code on behalf of Andrea Cosentino (@oscerd).

🤖 Generated with Claude Code

…d RemoveTargets localstack ITs

EventbridgePutRuleIT, EventbridgePutEventsIT and EventbridgeRemoveTargetsIT were
disabled with "Doesn't work with Localstack v4". They now pass against the
LocalStack image the AWS test-infra currently uses (mirror.gcr.io/floci/floci:1.5.28),
so the underlying behaviour has been fixed upstream.

Remove the @disabled annotations (and the now-unused imports) to re-enable them.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@oscerd oscerd added the test label Jul 23, 2026
@oscerd
oscerd requested review from davsclaus and gnodet July 23, 2026 10:05
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • components/camel-aws/camel-aws2-eventbridge

🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 9 all tested

Maveniverse Scalpel detected 1 affected modules (current approach: 9).

Modules only in current approach (8)
  • camel-jbang-mcp
  • camel-jbang-plugin-mcp
  • camel-jbang-plugin-route-parser
  • camel-jbang-plugin-tui
  • camel-jbang-plugin-validate
  • camel-launcher-container
  • camel-yaml-dsl-validator
  • camel-yaml-dsl-validator-maven-plugin

Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules)

Modules Scalpel would test (1)
  • camel-aws2-eventbridge

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more

All tested modules (9 modules)
  • Camel :: AWS2 Eventbridge
  • Camel :: JBang :: MCP
  • Camel :: JBang :: Plugin :: MCP
  • Camel :: JBang :: Plugin :: Route Parser
  • Camel :: JBang :: Plugin :: TUI
  • Camel :: JBang :: Plugin :: Validate
  • Camel :: Launcher :: Container
  • Camel :: YAML DSL :: Validator
  • Camel :: YAML DSL :: Validator Maven Plugin

⚙️ View full build and test results

@oscerd oscerd self-assigned this Jul 23, 2026
@oscerd oscerd added this to the 4.22.0 milestone Jul 23, 2026
@oscerd
oscerd merged commit 36fc371 into apache:main Jul 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants