CAMEL-21933: camel-aws2-eventbridge - re-enable PutRule, PutEvents and RemoveTargets localstack ITs - #25053
Merged
Merged
Conversation
…d RemoveTargets localstack ITs EventbridgePutRuleIT, EventbridgePutEventsIT and EventbridgeRemoveTargetsIT were disabled with "Doesn't work with Localstack v4". They now pass against the LocalStack image the AWS test-infra currently uses (mirror.gcr.io/floci/floci:1.5.28), so the underlying behaviour has been fixed upstream. Remove the @disabled annotations (and the now-unused imports) to re-enable them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
approved these changes
Jul 23, 2026
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 9 all testedMaveniverse Scalpel detected 1 affected modules (current approach: 9). Modules only in current approach (8)
Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules) Modules Scalpel would test (1)
All tested modules (9 modules)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CAMEL-21933.
EventbridgePutRuleIT,EventbridgePutEventsITandEventbridgeRemoveTargetsITwere disabled with "Doesn't work with Localstack v4".They now pass against the LocalStack image the AWS test-infra currently uses (
mirror.gcr.io/floci/floci:1.5.28), so the upstream behaviour that broke them has since been fixed.Changes
Remove the
@Disabled("Doesn't work with Localstack v4")annotation (and the now-unusedorg.junit.jupiter.api.Disabledimport) from the three ITs. Test-only change.Testing
Ran all three against LocalStack via the AWS test-infra:
Plus the module's 25 unit tests pass, and a full reactor
mvn clean install -DskipTestsfrom root succeeds.Claude Code on behalf of Andrea Cosentino (@oscerd).
🤖 Generated with Claude Code